Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92871: Postpone the removal of typing.{io,re} to 3.13 #98958

Merged
merged 1 commit into from
Nov 2, 2022
Merged

gh-92871: Postpone the removal of typing.{io,re} to 3.13 #98958

merged 1 commit into from
Nov 2, 2022

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Nov 1, 2022 •
edited by bedevere-bot
Loading

See #92873 for background. Cc @JelleZijlstra

Needs backport to Python 3.9+.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 1, 2022
@srittau srittau changed the title gh-92873: Postpone the removal of typing.{io,re} gh-92871: Postpone the removal of typing.{io,re} Nov 1, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2022
Closed
@AlexWaygood
Copy link
Member

Needs backport to Python 3.9+.

3.9 is now only receiving security-related updates, so we'll probably only be backporting to 3.10 and 3.11 :)

@AlexWaygood
Copy link
Member

We should probably also remove this line from the "What's New in Python 3.11" page:

cpython/Doc/whatsnew/3.11.rst

Line 1853 in 4564490

* The :class:`typing.io <typing.IO>` namespace

But maybe it would be better to do that in a separate PR, so that this one backports to 3.10 cleanly.

@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 1, 2022
@AlexWaygood AlexWaygood changed the title gh-92871: Postpone the removal of typing.{io,re} gh-92871: Postpone the removal of typing.{io,re} to 3.13 Nov 1, 2022
@gvanrossum gvanrossum removed their request for review November 1, 2022 17:44
@JelleZijlstra JelleZijlstra merged commit 65d1407 into python:main Nov 2, 2022
@miss-islington
Copy link
Contributor

Thanks @srittau for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@srittau @miss-islington
pythongh-92871: Postpone the removal of typing.{io,re} to 3.13 (pytho…
07be05c 
…nGH-98958)

(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@miss-islington
Copy link
Contributor

Sorry, @srittau and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 65d1407737befc3e9430eda8ae14ab1c7f9d8c7a 3.10

@bedevere-bot
Copy link

GH-98985 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 2, 2022
@bedevere-bot
Copy link

GH-98986 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 2, 2022
miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @srittau
gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-98958)
b2e28c8 
(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@srittau srittau deleted the typing-removals branch November 2, 2022 07:08
AlexWaygood pushed a commit that referenced this pull request Nov 2, 2022
@JelleZijlstra @srittau
[3.10] gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-9…
e07086d 
…8958) (#98986)

[3.10] gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-98958).
(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srittau @AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra